fix: compare docker images with latest release tag - #1736
Merged
Conversation
dunglas
approved these changes
Jul 9, 2025
Member
|
Thank you!! |
|
When will new docker images be built? e.g. Thanks! |
Contributor
Author
|
The new images (1.8.0 with PHP 8.4.10) should now be on Docker Hub |
|
Confirmed Thanks! |
|
Confirmed. Thanks! |
|
Sorry but this introduced an issue - details: #1742 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #1730 by always comparing upstream docker images to the actual latest release tag instead of the 'latest'
dunglas/frankenphp.(assuming this works as intended, since I can't test it locally)
The issue is that currently the 'latest' Docker version is 1.7, while the latest release is 1.8. This leads to the CI not upgrading the 1.8 version.